Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR #390

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Aug 14, 2023

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #381

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.22% ⚠️

Comparison is base (58b1461) 86.89% compared to head (14485d2) 86.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   86.89%   86.67%   -0.22%     
==========================================
  Files          23       23              
  Lines         824      833       +9     
==========================================
+ Hits          716      722       +6     
- Misses        108      111       +3     
Files Changed Coverage Δ
scripts/run.sh 87.90% <50.00%> (-1.93%) ⬇️
scripts/commands/help.sh 100.00% <100.00%> (ø)
scripts/lib/file.sh 85.00% <100.00%> (+0.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -x' returned error 1 finding the following syntactical issues:

----------

In tests/unit/template.bats line 2058:
    run env HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR=true WSLENV="HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR:${WSLENV}" \
                                                                                                         ^-------^ SC2031 (info): WSLENV was modified in a subshell. That change might be lost.

For more information:
  https://www.shellcheck.net/wiki/SC2031 -- WSLENV was modified in a subshell...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

@jkroepke jkroepke merged commit 91fceed into main Aug 14, 2023
16 checks passed
@jkroepke jkroepke deleted the encrypt-in-tmp-dor branch August 14, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store decryped file in temp folder
1 participant